Prevent crashing when mv warns and report warnings to the user instead.
#1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddeboer
force-pushed
the
fix-preserve-ownership
branch
2 times, most recently
from
6bfbba8 to
b8d80fd
Compare
|
Should there be a test for this as well? Not sure how I can mock |
| {ok, []} -> | ||
| ok; | ||
| {ok, Warning} -> | ||
| ?WARN("mv warning ~p", [Warning]), |
There was a problem hiding this comment.
I'd change the string to "mv: ~p" there.
|
A test would be good. We may not need to mock anything -- if we can make a file inside CT's To mock meck:new(rebar_utils, [passthrough]),
meck:expect(rebar_utils, sh, fun(<STRING_FOR_MV>, _) -> {ok, "Warning"} end),
ok = rebar_utils:mv(Src, Dest),
meck:unload(rebar_utils).We possibly do not need to test that the warning is being relayed, though that would be nicer and would require more mocking (and conditional test skips for windows runs). |
ddeboer
force-pushed
the
fix-preserve-ownership
branch
2 times, most recently
from
905a5a1 to
8457428
Compare
Added a test. Mocking, because I wasn’t able to reproduce |
ddeboer
force-pushed
the
fix-preserve-ownership
branch
from
8457428 to
e2c57e4
Compare
In some cases, mv will throw a warning, while still moving the files correctly and returning a 0 return code: "mv: can't preserve ownership of ... Permission denied".
ddeboer
force-pushed
the
fix-preserve-ownership
branch
from
e2c57e4 to
2b6fa7a
Compare
|
And now green. 😉 |
ferd
changed the title
mv warns and report warnings to the user instead.
|
Merging, thanks! |
|
Thank you for the help, Fred! |
Closed
ddeboer
added a commit
to zotonic/zotonic
that referenced
this pull request
Sep 21, 2016
* Switch to recent rebar3 build for erlang/rebar3#1326
ddeboer
added a commit
to zotonic/zotonic
that referenced
this pull request
Sep 21, 2016
* Switch to recent rebar3 build for erlang/rebar3#1326
ddeboer
added a commit
to zotonic/zotonic
that referenced
this pull request
Sep 21, 2016
* Switch to recent rebar3 build for erlang/rebar3#1326
ddeboer
added a commit
to zotonic/zotonic
that referenced
this pull request
Sep 21, 2016
* Switch to recent rebar3 build for erlang/rebar3#1326
ddeboer
added a commit
to zotonic/zotonic
that referenced
this pull request
Sep 21, 2016
* Switch to recent rebar3 build for erlang/rebar3#1326
ddeboer
added a commit
to zotonic/zotonic
that referenced
this pull request
Sep 21, 2016
* Switch to recent rebar3 build for erlang/rebar3#1326 * Add docker-compose.yml * Update docs
ddeboer
added a commit
to zotonic/zotonic
that referenced
this pull request
Sep 21, 2016
* Switch to recent rebar3 build for erlang/rebar3#1326 * Add docker-compose.yml * Update docs
ddeboer
added a commit
to zotonic/zotonic
that referenced
this pull request
Sep 21, 2016
* Switch to recent rebar3 build for erlang/rebar3#1326 * Add docker-compose.yml * Update docs
ddeboer
added a commit
to zotonic/zotonic
that referenced
this pull request
Sep 21, 2016
* Switch to recent rebar3 build for erlang/rebar3#1326 * Add docker-compose.yml * Update docs
ddeboer
added a commit
to zotonic/zotonic
that referenced
this pull request
Sep 21, 2016
* Switch to recent rebar3 build for erlang/rebar3#1326 * Add docker-compose.yml * Update docs
ddeboer
added a commit
to zotonic/zotonic
that referenced
this pull request
Sep 21, 2016
* Switch to recent rebar3 build for erlang/rebar3#1326 * Add docker-compose.yml * Update docs
ddeboer
added a commit
to zotonic/zotonic
that referenced
this pull request
Sep 21, 2016
* Switch to recent rebar3 build for erlang/rebar3#1326 * Add docker-compose.yml * Update docs
ddeboer
added a commit
to zotonic/zotonic
that referenced
this pull request
Sep 21, 2016
* Switch to recent rebar3 build for erlang/rebar3#1326 * Add docker-compose.yml * Update docs
ddeboer
added a commit
to zotonic/zotonic
that referenced
this pull request
Sep 21, 2016
* Switch to recent rebar3 build for erlang/rebar3#1326 * Add docker-compose.yml * Update docs
ddeboer
added a commit
to zotonic/zotonic
that referenced
this pull request
Sep 21, 2016
* Switch to recent rebar3 build for erlang/rebar3#1326 * Add docker-compose.yml * Update docs
ddeboer
added a commit
to zotonic/zotonic
that referenced
this pull request
Sep 21, 2016
* Switch to recent rebar3 build for erlang/rebar3#1326 * Add docker-compose.yml * Update docs
ddeboer
added a commit
to zotonic/zotonic
that referenced
this pull request
Sep 21, 2016
* Switch to recent rebar3 build for erlang/rebar3#1326 * Add docker-compose.yml * Update docs
ddeboer
added a commit
to zotonic/zotonic
that referenced
this pull request
Sep 21, 2016
* Switch to recent rebar3 build for erlang/rebar3#1326 * Add docker-compose.yml * Update docs
ddeboer
added a commit
to zotonic/zotonic
that referenced
this pull request
Sep 21, 2016
* Switch to recent rebar3 build for erlang/rebar3#1326 * Add docker-compose.yml * Update docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1324.
In some cases, mv will throw a warning, while still moving the files correctly and returning a 0 return code:
"mv: can't preserve ownership of ... Permission denied".